]> dgit.raspbian.org Git - gnome-shell.git/commit
windowManager: Unminimize a window to its buffer rect geometry
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Thu, 16 Dec 2021 07:36:43 +0000 (15:36 +0800)
committerMarge Bot <marge-bot@gnome.org>
Wed, 22 Dec 2021 16:16:23 +0000 (16:16 +0000)
commitca1291e418d71effd868909f90d3f9b5fd1b2565
treee85a3a92582d5c86d533205c97adc7ec1b340fa9
parent839793aa0cdfe3a7ae7a0ff56e60c863aee39124
windowManager: Unminimize a window to its buffer rect geometry

If you slow down the unminimize animation you will notice it overshoots and
then snaps back, but only for decorated windows. Undecorated windows would
unminimize to their correct position. So we remove decorations from the
equation and now all window types unminimize to their correct position.

This wasn't noticeable because the unminimize animation velocity is usually
so high at the end (EASE_IN_EXPO) that there are no frames rendered near the
end of the curve to show it had overshot.

This appears to be consistent with the Mutter source - associating the
actor geometry with `buffer_rect` and not `frame_rect`. See
`meta_window_actor_sync_actor_geometry` for example.

Related to: https://bugzilla.gnome.org/show_bug.cgi?id=786789#c1

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2066>
js/ui/windowManager.js